-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dashes in username #18
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 82.91% 82.91%
=======================================
Files 9 9
Lines 1124 1124
Branches 149 149
=======================================
Hits 932 932
Misses 131 131
Partials 61 61 Continue to review full report at Codecov.
|
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
@felixfontein, thanks for reviewing! |
@heuels should we do another release (1.0.2), or a wait a bit? The next Ansible release should be on January 5th, so we should definitely release before that, but we can also wait until January 4th :) |
@felixfontein, let's wait a bit — I just remembered I have #8 to fix. I'll be able to do it this week and after that I guess nothing is stopping us from releasing 1.0.2 🙂 |
@heuels would be 1.1.0 though since this is a feature PR, not a bugfix PR |
@felixfontein, sorry, I'm missing all the deadlines 😞 |
SUMMARY
Fixes #17.
ISSUE TYPE
COMPONENT NAME
community.routeros.command
,community.routeros.facts
ADDITIONAL INFORMATION